Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Dec 2, 2025

Motivation/summary

it uses the official Go downloads API

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues


This is an automatic backport of pull request #19201 done by [Mergify](https://mergify.com).

it uses the official Go downloads API

Co-authored-by: kruskall <99559985+kruskall@users.noreply.github.com>
(cherry picked from commit f174347)

# Conflicts:
#	.ci/scripts/bench.sh
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Dec 2, 2025
@mergify mergify bot assigned v1v Dec 2, 2025
@mergify
Copy link
Contributor Author

mergify bot commented Dec 2, 2025

Cherry-pick of f174347 has failed:

On branch mergify/bp/7.17/pr-19201
Your branch is up to date with 'origin/7.17'.

You are currently cherry-picking commit f1743471.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .buildkite/hooks/pre-command

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .ci/scripts/bench.sh

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@v1v v1v removed the conflicts There is a conflict in the backported pull request label Dec 2, 2025
@v1v v1v enabled auto-merge (squash) December 3, 2025 14:04
@v1v
Copy link
Member

v1v commented Dec 3, 2025

No clue what's the error about

Unable to setup go bootstrap from existing or binary
I don't have any idea what to do with '1.24.10'.
  (using download type 'auto')
Unable to setup go bootstrap from existing or binary
I don't have any idea what to do with '1.24.10'.
  (using download type 'auto')
make: /bin/go: No such file or directory
make: /bin/go: No such file or directory
/bin/bash: line 1: /bin/go: No such file or directory
make: *** [Makefile:276: build//bin/mage] Error 127

make: *** [Makefile:104: docker-system-tests] Error 2

@mergify
Copy link
Contributor Author

mergify bot commented Dec 8, 2025

This pull request has not been merged yet. Could you please review and merge it @v1v? 🙏

4 similar comments
@mergify
Copy link
Contributor Author

mergify bot commented Dec 15, 2025

This pull request has not been merged yet. Could you please review and merge it @v1v? 🙏

@mergify
Copy link
Contributor Author

mergify bot commented Dec 22, 2025

This pull request has not been merged yet. Could you please review and merge it @v1v? 🙏

@mergify
Copy link
Contributor Author

mergify bot commented Dec 29, 2025

This pull request has not been merged yet. Could you please review and merge it @v1v? 🙏

@mergify
Copy link
Contributor Author

mergify bot commented Jan 5, 2026

This pull request has not been merged yet. Could you please review and merge it @v1v? 🙏

@mergify mergify bot mentioned this pull request Jan 7, 2026
2 tasks
This resolves the issue running make system-tests from Docker Compose
due to a mismatch between go provided by the image and the go
desired by .go-version.
@endorama
Copy link
Contributor

endorama commented Jan 7, 2026

@v1v I found the culprit. There is an obscure tool called gimme that installed go and was using 1.24.10 from .go-version. But when run with Docker Compose the image was providing go 1.24.9 and this version mismatch created that error.

Updated the dockerfile makes the test pass locally, so now I'm waiting for the test to pass in CI too.

@endorama endorama self-assigned this Jan 7, 2026
The old GCS download links for Go don't work, which breaks
running make commands using gimme locally. Update them.

Updating would probably break downloading older versions,
but here we are only interested in being able to install
and use 1.24.10
@mergify mergify bot added the queued label Jan 7, 2026
mergify bot added a commit that referenced this pull request Jan 7, 2026
@mergify
Copy link
Contributor Author

mergify bot commented Jan 7, 2026

Merge Queue Status

✅ The pull request has been merged at 4c68381

This pull request spent 16 minutes 17 seconds in the queue, including 16 minutes 3 seconds running CI.
The checks were run on draft #20090.

Required conditions to merge

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

History

cc @endorama @v1v

@mergify mergify bot merged commit b38dbb2 into 7.17 Jan 7, 2026
19 checks passed
@mergify mergify bot deleted the mergify/bp/7.17/pr-19201 branch January 7, 2026 16:45
@mergify mergify bot removed the queued label Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants