-
Notifications
You must be signed in to change notification settings - Fork 542
[7.17] (backport #19201) deps: bump gvm dependency to 0.6.0 #19789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
it uses the official Go downloads API Co-authored-by: kruskall <99559985+kruskall@users.noreply.github.com> (cherry picked from commit f174347) # Conflicts: # .ci/scripts/bench.sh
|
Cherry-pick of f174347 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
🤖 GitHub commentsJust comment with:
|
|
No clue what's the error about |
|
This pull request has not been merged yet. Could you please review and merge it @v1v? 🙏 |
4 similar comments
|
This pull request has not been merged yet. Could you please review and merge it @v1v? 🙏 |
|
This pull request has not been merged yet. Could you please review and merge it @v1v? 🙏 |
|
This pull request has not been merged yet. Could you please review and merge it @v1v? 🙏 |
|
This pull request has not been merged yet. Could you please review and merge it @v1v? 🙏 |
This resolves the issue running make system-tests from Docker Compose due to a mismatch between go provided by the image and the go desired by .go-version.
|
@v1v I found the culprit. There is an obscure tool called Updated the dockerfile makes the test pass locally, so now I'm waiting for the test to pass in CI too. |
The old GCS download links for Go don't work, which breaks running make commands using gimme locally. Update them. Updating would probably break downloading older versions, but here we are only interested in being able to install and use 1.24.10
Merge Queue Status✅ The pull request has been merged at 4c68381 This pull request spent 16 minutes 17 seconds in the queue, including 16 minutes 3 seconds running CI. Required conditions to merge
|
💚 Build Succeeded
History
|
Motivation/summary
it uses the official Go downloads API
Checklist
For functional changes, consider:
How to test these changes
Related issues
This is an automatic backport of pull request #19201 done by [Mergify](https://mergify.com).